Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedding example #6956

Merged
merged 1 commit into from
Dec 25, 2017
Merged

Fix embedding example #6956

merged 1 commit into from
Dec 25, 2017

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Dec 25, 2017 •
edited

fix #6837

pkuyym
pkuyym approved these changes Dec 25, 2017
View reviewed changes
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit d3c42f7 into PaddlePaddle:develop Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuyym pkuyym pkuyym approved these changes

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example for paddle.v2.fluid.layers.embedding maybe not right.
2 participants
@chengduoZH @pkuyym