Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python API for im2sequence op #7595

Merged
merged 7 commits into from
Jan 23, 2018
Merged

Add python API for im2sequence op #7595

merged 7 commits into from
Jan 23, 2018

Conversation

wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Jan 17, 2018 •
edited

Add python API for im2sequence op
fix #7594
Notice: this pr depend on #4866

@wanghaoshuang wanghaoshuang moved this from TODO to DOING in Computer Vision on Fluid Jan 17, 2018
@wanghaoshuang wanghaoshuang self-assigned this Jan 17, 2018
@JiayiFeng
Copy link
Collaborator

Do we have to use the name block_expand? Block is a core concept in the Fluid. This op seems to have nothing to do with it. So such a name is a little confusing.

@wanghaoshuang
Copy link
Contributor Author

@JiayiFeng Thx.
We will discuss the naming of this operator. And it is being reviewed.
#4866 (comment)

@wanghaoshuang wanghaoshuang changed the title Add python API for block expand op Add python API for im2sequence op Jan 18, 2018
@wanghaoshuang wanghaoshuang requested review from JiayiFeng and removed request for gongweibao January 23, 2018 04:08
JiayiFeng
JiayiFeng reviewed Jan 23, 2018
View reviewed changes
python/paddle/v2/fluid/layers/nn.py Outdated
stride=1,
padding=0,
name=None,
layer_attr=None):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param_attr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Removed layer_attr / param_attr because this hasn't parameter.

@wanghaoshuang wanghaoshuang merged commit 9536c4e into PaddlePaddle:develop Jan 23, 2018
@wanghaoshuang wanghaoshuang moved this from DOING to DONE in Computer Vision on Fluid Jan 23, 2018
@wanghaoshuang wanghaoshuang deleted the block_expand_py branch May 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@pkuyym pkuyym Awaiting requested review from pkuyym

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees

@wanghaoshuang wanghaoshuang

Labels
None yet
Projects
Computer Vision on Fluid
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python API for block expand op
2 participants
@wanghaoshuang @JiayiFeng