-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/lod #7714
Fix/lod #7714
Conversation
paddle/framework/lod_tensor.h
Outdated
|
||
void CopyFromCUDA(); | ||
|
||
void CopyToPeer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a flag for data has been at GPU memory, and do not copy it again.
We should overload all method of std::vector and maintain this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed at PyCUDATensorSetFromArray
when calling set
from python.
paddle/framework/lod_tensor_test.cu
Outdated
#include "paddle/framework/lod_tensor.h" | ||
#include "paddle/platform/assert.h" | ||
|
||
#include <glog/logging.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glog
seems not used in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can merge this now. The file name mixed_vector.h
can be renamed to other more meaningful name as we discussed offline.
fix #7713
fix #7204
and dzhwinter/benchmark#60