Multihead scaled dot product attention. #7791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
force-pushed
the
multihead_attention
branch
2 times, most recently
from
7442fe0
to
4a24f76
Compare
lcy-seso
force-pushed
the
multihead_attention
branch
2 times, most recently
from
9c550a9
to
c0ac68b
Compare
lcy-seso
force-pushed
the
multihead_attention
branch
from
c0ac68b
to
90f334e
Compare
lcy-seso
force-pushed
the
multihead_attention
branch
from
90f334e
to
d163592
Compare
guoshengCS
previously approved these changes
Jan 24, 2018
lcy-seso
force-pushed
the
multihead_attention
branch
from
dc11205
to
738cc13
Compare
guoshengCS
previously approved these changes
Jan 24, 2018
lcy-seso
force-pushed
the
multihead_attention
branch
2 times, most recently
from
f4e5bd0
to
d6f2d79
Compare
lcy-seso
force-pushed
the
multihead_attention
branch
from
d6f2d79
to
d00eb53
Compare
guoshengCS
reviewed
Jan 24, 2018
python/paddle/v2/fluid/layers/nn.py
Outdated
| if len(x_shape) == 1: | ||
| x_shape = [1] + x_shape | ||
| if len(y_shape) == 1: | ||
| y_shape = [1] + y_shape |
There was a problem hiding this comment.
If the rank of y is 1, it is treated as [D, 1] in nontransposed form.
python/paddle/v2/fluid/nets.py
Outdated
| [bs, max_sequence_length, num_heads * hidden_dim]. | ||
| """ | ||
|
|
||
| if len(x.shape) == 3: return |
There was a problem hiding this comment.
Might it be return x here.
guoshengCS
reviewed
Jan 24, 2018
doc/api/v2/fluid/nets.rst
Outdated
| dot_product_attention | ||
| --------------------- | ||
| scaled_dot_product_attention | ||
| ---------------------------- | ||
| .. autofunction:: paddle.v2.fluid.nets.dot_product_attention |
There was a problem hiding this comment.
Might it be paddle.v2.fluid.nets.scaled_dot_product_attention here.
guoshengCS
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.