Enhancement/transpiler rename grad vars to add trainer id, so RPC call can be retried. #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no_counter_on_pserver
… no_counter_on_pserver
… no_counter_on_pserver
|
|
… no_counter_on_pserver
… no_counter_on_pserver
typhoonzero
changed the title
typhoonzero
changed the title
gongweibao
approved these changes
Feb 13, 2018
| optimize_ops, params_grads, pservers=pserver_endpoints, trainers=trainers) | ||
| optimize_ops, | ||
| params_grads, | ||
| 0, |
There was a problem hiding this comment.
Need to get trainer_id from ENV or command-line arguments.
I will fix it in a new PR.
helinwang
reviewed
Feb 21, 2018
| # step3 | ||
| optimize_block = pserver_program.create_block(0) | ||
| # step 4 | ||
| # Create a union-find data struct from optimize ops, |
There was a problem hiding this comment.
Thanks for the detailed documentation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7947 (comment), we can delete
fan_inattribute inlisten_and_servop, so RPC calls can be retried when the network sucks.