Fix parallel.do with batch norm #8186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
commented
Feb 6, 2018
paddle/operators/parallel_do_op.cc
Outdated
| @@ -248,6 +248,8 @@ class ParallelDoGradOp : public framework::OperatorBase { | |||
| const std::vector<framework::Scope *> &sub_scopes, | |||
| const platform::PlaceList &places) const { | |||
| for (auto &s : Outputs(framework::GradVarName(kParameters))) { | |||
| VLOG(10) << "Accumulating " << s; | |||
| if (s == framework::kEmptyVarName) continue; | |||
There was a problem hiding this comment.
Do not accumulate @EMPTY@
reyoung
commented
Feb 6, 2018
| PADDLE_ENFORCE(ctx->HasOutputs(framework::GradVarName(kParameters))); | ||
| ctx->SetOutputsDim(framework::GradVarName(kParameters), | ||
| ctx->GetInputsDim(kParameters)); | ||
| auto p_dims = ctx->GetInputsDim(kParameters); |
There was a problem hiding this comment.
If parameter gradient is empty, do not infer shape.
reyoung
commented
Feb 6, 2018
| @@ -274,21 +274,20 @@ def get_parameters(self): | |||
| parent_block = self.parent_block() | |||
|
|
|||
| local_inputs = set() | |||
|
|
|||
There was a problem hiding this comment.
The previous logic cannot calculate parameters that used and updated by the same operator.
|
For the purpose of this PR, please ignore the nccl error: Update: it turns out the driver version of 199 is not enough. @helinwang is updating it. |
… feature/parallel_do_and_batch_norm
|
Merged by #8249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #8153