Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Initial GO_OP implementation and Unit tests (DO NOT MERGE) #8496

Closed
wants to merge 28 commits into from
Closed

[WIP] Initial GO_OP implementation and Unit tests (DO NOT MERGE) #8496

wants to merge 28 commits into from

Conversation

cs2be
Copy link
Contributor

@cs2be cs2be commented Feb 22, 2018

This is a work in progress:

  • Go Op currently will take in a sub_block and execute it.
  • Currently Go Op will enforce all variables used by operators are in global or current local scope. It will not allow variables defined in parent scope now, since fluid does not fully support closures. We will provide proposal for supporting closures in a future github issue.
  • Create unit test that will run a single sum operator in a seperate thread. Will expand tests in the final pull request.

Abhinav Arora and others added 28 commits February 12, 2018 17:32
Adding Python boilerplate code for Go op
497321a
Add very basic test case
f2a95fa
Adding the python logic for go routine
d785ca9
Fix syntax
313ffb0
Changing test to notest
a43924e
Rename Routine to Go
c97cf4a
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
39f22cf 
… go_op
Combining GoGuard and Go in one class
fc2593c
Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…
24737a6 
…o_op
Modify test
8343a35
Adding fluid close channel
d0e26f7
Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…
ccb37b9 
…o_op
Fixing __init__.py for calling fluid.go()
a37a1e1
Merge branch 'go_op' of https://github.com/abhinavarora/Paddle into g…
2fb93ca 
…o_op
Adding stubs for channel methods and updating test case
f5f6370
Removing import *
323a2e2
Merge branch 'go_op' of github.com:abhinavarora/Paddle into go_op
d02873b
Merge remote-tracking branch 'origin/develop' into go_op
04cb0f3
Adding imports from concurrency
47f9680
@cs2be
Initial commit of GO_OP (for varun)
802eb42
@cs2be
Merge branch 'develop' of github.com:PaddlePaddle/Paddle into go_op_t…
934352a 
…huan_varun

# Conflicts:
#	python/paddle/v2/fluid/__init__.py
#	python/paddle/v2/fluid/concurrency.py
Creating local scopes and go through them
3697796
Updated go op inputs persistability enforcement
d690a83
Add thread execution; compile failing though
e87aabb
@cs2be
Fix go op
60dd07b
@cs2be
Cleaned up Go op
9abc486
@cs2be
Fix yapf format issue
8b8d208
@cs2be
Readd warp ctc dir for unit tests
756af7b
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@cs2be cs2be closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

@varunarora varunarora Awaiting requested review from varunarora

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@kavyasrinet kavyasrinet Awaiting requested review from kavyasrinet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cs2be @CLAassistant