Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine batch_size_like.cc into batch_size_like.h #8604

Merged
merged 1 commit into from
Feb 27, 2018
Merged

combine batch_size_like.cc into batch_size_like.h #8604

merged 1 commit into from
Feb 27, 2018

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Feb 27, 2018

fix #8602

Xreki
Xreki reviewed Feb 27, 2018
View reviewed changes
paddle/fluid/operators/batch_size_like.h Outdated
@@ -24,12 +24,50 @@ class BatchSizeLikeOp : public framework::OperatorWithKernel {
public:
using framework::OperatorWithKernel::OperatorWithKernel;

void InferShape(framework::InferShapeContext *ctx) const override;
void InferShape(framework::InferShapeContext *ctx) const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数是否需要保留override属性？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 已保留。

Xreki
Xreki approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit d742f4e into PaddlePaddle:develop Feb 27, 2018
@luotao1 luotao1 deleted the batch_size_like branch February 27, 2018 09:40
@Xreki Xreki added the 预测 原名Inference，包含Capi预测问题等 label Feb 28, 2018
@kexinzhao kexinzhao added this to Basic Usage (DONE) in Inference Framework Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
预测 原名Inference，包含Capi预测问题等
Projects
No open projects
Inference Framework
Basic Usage (DONE)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

combine batch_size_like.cc into batch_size_like.h
2 participants
@luotao1 @Xreki