Add CPU time and MemCopy to the timeline. #8679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
requested review from
wangkuiyi,
jacquesqiao,
qingqing01 and
chengduoZH
panyx0718
changed the title
jacquesqiao
reviewed
Mar 2, 2018
| std::string MemcpyKind(CUpti_ActivityMemcpyKind kind) { | ||
| switch (kind) { | ||
| case CUPTI_ACTIVITY_MEMCPY_KIND_HTOD: | ||
| return "MEMCPYHtoD"; |
There was a problem hiding this comment.
Maybe just HtoD is ok? There are many duplicates MEMCPY
There was a problem hiding this comment.
I Added it back. User can search MEMCPY to find all copy.
jacquesqiao
reviewed
Mar 2, 2018
| @@ -15,12 +15,17 @@ limitations under the License. */ | |||
| syntax = "proto2"; | |||
| package paddle.platform.proto; | |||
|
|
|||
| message MemCopy { optional uint64 bytes = 3; } | |||
jacquesqiao
reviewed
Mar 2, 2018
| event->set_start_ns(r.start_ns); | ||
| event->set_end_ns(r.end_ns); | ||
| event->set_stream_id(r.thread_id); | ||
| event->set_device_id(-1); |
There was a problem hiding this comment.
use a const value to represent CPU instead of -1, like
const kCpuDeviceId = -1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.