Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building error of missing end-group for Android. #8680

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Fix building error of missing end-group for Android. #8680

merged 1 commit into from
Mar 1, 2018

Conversation

Xreki
Copy link
Contributor

@Xreki Xreki commented Mar 1, 2018 •
edited
Loading

Fix #8640
Fix #8612

@Xreki Xreki added the Android label Mar 1, 2018
@Xreki Xreki requested a review from luotao1 March 1, 2018 09:42
luotao1
luotao1 approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we have an android Travis-CI later to avoid these problems?

@Xreki
Copy link
Contributor Author

Xreki commented Mar 1, 2018

Can we have an android Travis-CI later to avoid these problems?

OK. Will do that.

@Xreki Xreki merged commit ae2026e into PaddlePaddle:develop Mar 1, 2018
@Xreki Xreki mentioned this pull request Mar 2, 2018
Merged
@yeyupiaoling yeyupiaoling mentioned this pull request Mar 4, 2018
Closed
@Xreki Xreki deleted the build_fix_android_endgroup branch March 5, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xreki @luotao1