-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the doc in detection_output API. #8689
Conversation
This layer applies the NMS to the output of network and computes the | ||
predict bounding box location. The output's shape of this layer could | ||
be zero if there is no valid bounding box. | ||
This operation decode the predicted bboxes according to the prior bboxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This operation updates bounding boxes by applying multi-class non-maximum suppression (NMS) and re-scoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-write the doc. Thanks!
@@ -91,7 +92,14 @@ class number, M is number of bounding boxes. For each category | |||
nms_eta(float): The parameter for adaptive NMS. | |||
|
|||
Returns: | |||
The detected bounding boxes which are a Tensor. | |||
Variable: The detection outputs which is a LoDTensor with shape [No, 6]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a comma (,) before "which".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-write the doc. Thanks!
@@ -91,7 +92,14 @@ class number, M is number of bounding boxes. For each category | |||
nms_eta(float): The parameter for adaptive NMS. | |||
|
|||
Returns: | |||
The detected bounding boxes which are a Tensor. | |||
Variable: The detection outputs which is a LoDTensor with shape [No, 6]. | |||
Each row has 6 values: [label, confidence, xmin, ymin, xmax, ymax], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use six instead 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
offset is N + 1, N is the batch size. If LoD[i + 1] - LoD[i] == 0, | ||
means there is no detected bboxes for for i-th image. If there is | ||
no detected boxes for all images, all the elements in LoD are 0, | ||
and the Out only contains one value which is -1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Out => Out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-write the doc. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #8685