Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine document of build_and_install #8737

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Refine document of build_and_install #8737

merged 2 commits into from
Mar 5, 2018

Conversation

pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Mar 5, 2018

Fixes #8211

@pkuyym pkuyym requested review from luotao1 and shanyi15 March 5, 2018 05:50
luotao1
luotao1 approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shanyi15
shanyi15 reviewed Mar 5, 2018
View reviewed changes
Copy link
Collaborator

@shanyi15 shanyi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 08e9bfa into PaddlePaddle:develop Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanyi15 shanyi15 shanyi15 left review comments

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkuyym @luotao1 @shanyi15