Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix snappy build #8804

Merged
merged 1 commit into from
Mar 6, 2018
Merged

fix snappy build #8804

merged 1 commit into from
Mar 6, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Mar 6, 2018 •
edited

fix #8805

qingqing01
qingqing01 approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested on Linux.

@jacquesqiao jacquesqiao changed the title fix snappy build on macos fix snappy build Mar 6, 2018
@jacquesqiao jacquesqiao merged commit 351795e into PaddlePaddle:develop Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snappy build on macos will fail
2 participants
@jacquesqiao @qingqing01