Fix typo #8848
Closed
Fix typo #8848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavarora
reviewed
Mar 7, 2018
doc/design/profiler.md
Outdated
| @@ -12,22 +12,22 @@ for i in xrange(M): # M is the iteration number | |||
| op.run(); | |||
| ``` | |||
|
|
|||
| In summary, the proflier should have following features: | |||
| In summary, the profiler should have following features: | |||
There was a problem hiding this comment.
have following features -> have the following features
doc/design/profiler.md
Outdated
|
|
||
| - records time span in loop. | ||
| - records time span in a loop. |
There was a problem hiding this comment.
It would be good to capitalize the first letter of each of these points
doc/design/profiler.md
Outdated
| - supports nested time span. | ||
| - supports multiple threads/multiple GPUs. | ||
| - supports to be enabled and disabled by users. | ||
|
|
||
| But how to record the time for the mixed C++ and CUDA program? There many C++ APIs to get the current calendar time in host program. But for GPU, the CUDA kernels may be executed concurrently if they are in different [streams](http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#streams) and the CUDA kernels is asynchronous with the host program if there is no the synchronous aftern the CUDA kernels. CUDA provides [event](http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#events) to monitor the device and perform accurate timing. Inspired by PyTorch and CUDA event, we also design and apply the events to record the timeline. Then summarize and present statistics based on these events. | ||
| But how to record the time for the mixed C++ and CUDA program? There many C++ APIs to get the current calendar time in the host program. But for GPU, the CUDA kernels may be executed concurrently if they are in different [streams](http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#streams) and the CUDA kernels are asynchronous with the host program if there is no the synchronous after the CUDA kernels. CUDA provides [event](http://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#events) to monitor the device and performs accurate timing. Inspired by PyTorch and CUDA event, we also design and apply the events to record the timeline. Then summarize and present statistics based on these events. |
There was a problem hiding this comment.
the mixed C++ and CUDA program -> a mixed C++ and CUDA program
doc/design/profiler.md
Outdated
|
|
||
| <img src="./images/profiler.png" align="center"/><br/> | ||
|
|
||
| ### Event | ||
|
|
||
| In above work flow, a pair of events are needed before and after the piece of code to collect time. So the event has a flag to mark whether it is a starting event or an ending event. Except this two kinds of event, sometime, a only marker with a text message is needed, for example, a marker to specify the profiling start or end. There are three kinds of event: | ||
| In above work flow, a pair of events is needed before and after the piece of code to collect time. So the event has a flag to mark whether it is a starting event or an ending event. Except this two kinds of event, sometimes, an only marker with a text message is needed, for example, a marker to specify the profiling start or end. There are three kinds of event: |
There was a problem hiding this comment.
Except this two kinds -> Except for these two kinds
kuke
reviewed
Mar 8, 2018
doc/design/profiler.md
Outdated
| - supports nested time span. | ||
| - supports multiple threads/multiple GPUs. | ||
| - supports to be enabled and disabled by users. | ||
| - Record time span in a loop. |
There was a problem hiding this comment.
Should be Records due to profiler. The same below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.