Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context wait in data_type_transform #8850

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Add context wait in data_type_transform #8850

merged 1 commit into from
Mar 7, 2018

Conversation

kexinzhao
Copy link
Contributor

@kexinzhao kexinzhao commented Mar 7, 2018 •
edited

Fix #8852

@kexinzhao kexinzhao changed the title [WIP] Add context wait in data_type_transform Add context wait in data_type_transform Mar 7, 2018
sidgoyal78
sidgoyal78 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think looks good to me. As clarified in person with @kexinzhao, the PR primarily focusses on adding explicit wait() calls for proper sequential execution.

@kexinzhao kexinzhao merged commit 7f00716 into PaddlePaddle:develop Mar 7, 2018
@Xreki Xreki added the 预测 原名Inference，包含Capi预测问题等 label Mar 8, 2018
@kexinzhao kexinzhao mentioned this pull request Mar 8, 2018
Closed
34 tasks
@kexinzhao kexinzhao added this to Performance Tuning (DONE) in Inference Framework Mar 15, 2018
@Xreki Xreki moved this from Performance Tuning (DONE) to Support FP16 in Inference Framework Apr 3, 2018
@kexinzhao kexinzhao deleted the fix_data_type_trans_test branch April 4, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidgoyal78 sidgoyal78 sidgoyal78 approved these changes

Assignees
No one assigned
Labels
预测 原名Inference，包含Capi预测问题等
Projects
No open projects
Inference Framework
Support FP16
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kexinzhao @sidgoyal78 @Xreki