Enhance look_up_table op #8932
Merged
Enhance look_up_table op #8932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2018
Merged
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
6 times, most recently
from
0c7b04b
to
5f1b8eb
Compare
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
from
5f1b8eb
to
f1c3ecb
Compare
jacquesqiao
reviewed
Mar 12, 2018
| @@ -85,6 +91,44 @@ or not. And the output only shares the LoD information with input Ids. | |||
| } | |||
| }; | |||
|
|
|||
| class ConcatRowsOpMaker : public framework::OpProtoAndCheckerMaker { | |||
There was a problem hiding this comment.
I think this name is not so good and maybe we just need a python layer but not a new operator
There was a problem hiding this comment.
Thanks for your review @jacquesqiao
The parameters' meaning of ConcatRowsOp are different with LookUpTableOp, and the two operations' function is also different, so I define the new operation(ConcatRows). And I have added some annotation in the code.
Is your meaning that ConcatRowsOp is unnecessary?
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
from
9140f73
to
b9397b2
Compare
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
from
5de8215
to
1f757f5
Compare
… feature/add_concat_rows
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
3 times, most recently
from
c9072d6
to
94e43e9
Compare
chengduoZH
force-pushed
the
feature/add_concat_rows
branch
from
94e43e9
to
92e2207
Compare
jacquesqiao
reviewed
Mar 13, 2018
| W_array[i] *= i | ||
| W.set(W_array, place) | ||
|
|
||
| Out = scope.var('Out').get_selected_rows() |
jacquesqiao
reviewed
Mar 13, 2018
| result_array = np.array(Out_tensor) | ||
|
|
||
| for idx, row in enumerate(rows): | ||
| assert (row == result_array[idx]).all() |
There was a problem hiding this comment.
please add a comments about this usage of numpy.array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8933