Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modification to Channel to support Select OP #9084

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

abhinavarora
Copy link
Contributor

Fixes #8815
Fixes #8864
Fixes #8863
Fixes #9083

This PR does the following:

  1. Implement a non-blocking CanSend and CanReceive for Channels
  2. Exposes methods to the channel to externally add tasks on SendQueue and RecvQueue. These will be called by the Select op
  3. Add IsClosed method, that will be used by select op
  4. Allows QueueMessage to support callbacks. This callback will be provided by the select op. The callback will be used by the select op to keep a track of the case that is executed.
  5. Provides the ability to share condition variable in the QueueMessage for different channels.

@abhinavarora abhinavarora merged commit 41894da into PaddlePaddle:develop Mar 14, 2018
@abhinavarora abhinavarora deleted the channel_select branch March 14, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants