Support copy in Fluid channels #9138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs2be
previously approved these changes
Mar 15, 2018
python/paddle/fluid/concurrency.py
Outdated
| capacity=value.capacity) | ||
|
|
||
| assign_op = channel_send_block.append_op( | ||
| type="assign_op", inputs={"X": value, }, outputs={"Out": copied_X}) |
There was a problem hiding this comment.
although this is valid python syntax, I'm wondering if we can remove the extra "," after value
cs2be
approved these changes
Mar 15, 2018
chengduoZH
reviewed
Mar 16, 2018
| @@ -141,6 +141,8 @@ def channel_send(channel, value): | |||
| channel (Variable|Channel): Channel variable created using | |||
| `make_channel`. | |||
| value (Variable): Value to send to channel | |||
| copy (bool): Copy data while channel send. If False, then data | |||
| is moved. The input cannot be used after move. | |||
There was a problem hiding this comment.
Please add the default value of copy at the end of line145.
Maybe replacing copy with copy_mode is better.
There was a problem hiding this comment.
Sorry, I just realized that I missed your comment and merged the PR. I agree with you. Let me correct it and send you the review separately.
There was a problem hiding this comment.
it doesn't matter, the current scenario for using channel is still less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9085