Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python wrapper for Adadelta optimizer #9213

Merged
merged 4 commits into from
Mar 20, 2018
Merged

Add python wrapper for Adadelta optimizer #9213

merged 4 commits into from
Mar 20, 2018

Conversation

wanghaoshuang
Copy link
Contributor

fix #9212

qingqing01
qingqing01 reviewed Mar 20, 2018
View reviewed changes
python/paddle/fluid/optimizer.py Outdated
@@ -580,6 +582,58 @@ def _append_optimize_op(self, block, param_and_grad):
return decayed_adagrad_op


class AdadeltaOptimizer(Optimizer):
"""Simple Adadelta optimizer with average squared grad state and
average squared update state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more detailed doc. like https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/operators/adadelta_op.cc#L99 or like： http://www.paddlepaddle.org/docs/develop/api/en/config/optimizer.html#adadelta

python/paddle/fluid/optimizer.py Outdated
def __init__(self, learning_rate, epsilon=1.0e-6, rho=0.95, **kwargs):
assert learning_rate is not None
assert epsilon is not None
assert rho is not None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use raise not assert.

qingqing01
qingqing01 approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wanghaoshuang wanghaoshuang merged commit 7e526a6 into PaddlePaddle:develop Mar 20, 2018
@wanghaoshuang wanghaoshuang deleted the adadelta branch March 20, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@pkuyym pkuyym Awaiting requested review from pkuyym

@chengduoZH chengduoZH Awaiting requested review from chengduoZH

@guoshengCS guoshengCS Awaiting requested review from guoshengCS

@wanghaox wanghaox Awaiting requested review from wanghaox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python wrapper for Adadelta optimizer
2 participants
@wanghaoshuang @qingqing01