Expose a interface to create all variables and enable the test of not creating variables every time. #9301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
moved this from Basic Usage (DOING)
to Performance Tuning (DOING)
in Inference Framework
Xreki
changed the title
Superjomn
reviewed
Apr 4, 2018
| @@ -169,8 +169,14 @@ void TestInference(const std::string& dirname, | |||
|
|
|||
| // 6. Run the inference program | |||
| { | |||
| const bool create_vars = false; | |||
| if (!create_vars) { | |||
| executor.CreateVariables(*inference_program, scope, 0); | |||
There was a problem hiding this comment.
just some trivial issues, !create_vars -> executor.CreateVariables( seems a little wried.
There was a problem hiding this comment.
create_vars意思是在executor.Run函数里面是否创建Variables，默认值为true，意思是每次Run都会create和destroy所有的Variables。如果executor.Run时设置参数create_vars为false，那么用户需要提前手动CreateVaribales，不然就会出现变量不存在的错误。
There was a problem hiding this comment.
能否增加一个单测说明create_vars为false时，用户如何提前手动CreateVaribales？
There was a problem hiding this comment.
Done。在image classification里面加了create_vars为false的单测。
Xreki
moved this from Performance Tuning (DOING)
to Performance Tuning (DONE)
in Inference Framework
Xreki
moved this from Performance Tuning (DONE)
to Basic Usage (DONE)
in Inference Framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9653
Sometimes users do not want to create and destroy variables in every run.
Here is the performance comparision for
test_inference_image_classificaion_resnet.GPU: Tesla K40m, CUDA 8.0, CUDNN v7.