Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"polish code" #9318

Merged
merged 4 commits into from
Apr 2, 2018
Merged

"polish code" #9318

merged 4 commits into from
Apr 2, 2018

Conversation

dzhwinter
Copy link
Contributor

polish executor python code

# TODO(dzhwinter) : only use the first place
self.executor = core.Executor(act_places[0])
def __init__(self, place):
self.executor = core.Executor(place)
self.places = places
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

places is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

self.program_caches = dict()

def aslodtensor(self, data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm removing parsing lod is OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We plan to use the nested numpy array to represent a LodTensor, but now we use two structure to do the same thing-- an array of data, a list of lod.

@dzhwinter dzhwinter merged commit 6cfc0c1 into PaddlePaddle:develop Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants