Fix concat_op #9337
Merged
Fix concat_op #9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkuyym
reviewed
Mar 24, 2018
| self.axis = 1 | ||
|
|
||
|
|
||
| class TestConcatOp2(OpTest): |
There was a problem hiding this comment.
Seems that this case is somehow duplicated with the above one, how about change to test axis==0?
There was a problem hiding this comment.
No, there are two CUDA kernels for Concat, they represent two case, TestConcatOp only covers one, TestConcatOp2 can covers the other.
| outputs_ptr[i] = outputs[i].data<T>(); | ||
| } | ||
|
|
||
| T** outs_gpu = | ||
| T** dev_out_gpu_data = | ||
| reinterpret_cast<T**>(outputs_data.CUDAMutableData(context.GetPlace())); |
There was a problem hiding this comment.
Please double check that whether static_cast is more suitable.
chengduoZH
force-pushed
the
feature/fix_concat
branch
from
4efe843
to
b68d53e
Compare
… feature/fix_concat
chengduoZH
force-pushed
the
feature/fix_concat
branch
from
b68d53e
to
aca9180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.