Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare pserver executor #9377

Merged

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Mar 26, 2018

Background: #8638

Yancey1989
Yancey1989 previously approved these changes Apr 2, 2018
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and one comment.

framework::Async([&executor, &prepared, &program, &scope, idx]() {
int run_block = idx; // thread local
try {
// executor->Run(*program, scope, run_block, false, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May delete the unused codes.

Yancey1989
Yancey1989 previously approved these changes Apr 3, 2018
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@typhoonzero typhoonzero merged commit fb8c1cf into PaddlePaddle:develop Apr 4, 2018
@typhoonzero typhoonzero deleted the prepare_pserver_executor branch April 4, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants