Create go_op design doc #9389
Create go_op design doc #9389
Conversation
doc/fluid/design/concurrent/go_op.md
Outdated
|
|
||
| ## Current Limitations | ||
|
|
||
| ####<a name="block-captures"></a>Scopes and block captures: |
doc/fluid/design/concurrent/go_op.md
Outdated
|
|
||
| ## How it Works | ||
|
|
||
| Similair to other control blocks, go_op will create a sub block and add it |
| ## Introduction | ||
|
|
||
| The **go_op** allows user's of PaddlePaddle to run program blocks on a detached | ||
| thread. It works in conjuction with CSP operators (channel_send, |
There was a problem hiding this comment.
just a quick formatting note: if you wrap terms like channel_send with the character next to 1 on your keyboard, it becomes much easier to read channel_send throughout the doc
doc/fluid/design/concurrent/go_op.md
Outdated
| the executor.run method (along with a newly created local scope) on a detached | ||
| thread. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Provide some commentary into this programdesc dump if you want people to use it as a reference
| scope, it may receive a segmentation fault because the parent scope may have | ||
| been deleted. | ||
|
|
||
| We need to implement block closures in order to prevent access to parent |
There was a problem hiding this comment.
You can also say that we explicitly enforce this.
doc/fluid/design/concurrent/go_op.md
Outdated
|
|
||
| Please refer to [Closure issue](https://github.com/PaddlePaddle/Paddle/issues/8502) | ||
| for more details. | ||
|
|
There was a problem hiding this comment.
If you want to make a note on how to debug the thread, this would also be a good point of info. The way you told me to do the try-catches and eventually remove the running of things in the thread entirely
There was a problem hiding this comment.
Another section or para I think would be useful is the choice of threading system. And that for now we are not using green threads.
There was a problem hiding this comment.
I'll mention about green threads. I won't mention the try catch because the user will only run into this issue if they run gtest
| #### Backward Propegation: | ||
|
|
||
| go_op currently does not support backwards propagation. Please use go_op with | ||
| non training operators. |
There was a problem hiding this comment.
Where are you going to write a detailed explanation of the considerations and challenges associated with backprop in go? This wouldn't be a terrible place.
There was a problem hiding this comment.
I'll leave this for later...
No description provided.