Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix submit_local's paddle pip name issue #9392

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

putcn
Copy link
Contributor

@putcn putcn commented Mar 26, 2018

fix: #9391
fix #7476

the issue is about syntax issue when run the default command "paddle version" from production docker image.

[root@k8s-node1 ~]# docker run --rm -it putcn/paddle:pro
/usr/local/bin/paddle: line 158: [: 0.10.0: binary operator expected
  File "<stdin>", line 3
    if LooseVersion("0.10.0
                          ^
SyntaxError: EOL while scanning string literal

the fix is to adding a pair of missing quote, and corrected the logic grabbing the current paddle version

@putcn putcn added the Docker label Mar 26, 2018
@putcn putcn requested review from reyoung and luotao1 March 26, 2018 23:20
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have tested paddle version, which shows normally now.

@luotao1 luotao1 merged commit ab41c5d into PaddlePaddle:develop Mar 28, 2018
@putcn putcn deleted the fix-submit-local branch April 25, 2018 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paddle production docker image default command error Error when running "paddle version"
2 participants