Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slr deser #9409

Merged
merged 3 commits into from
Mar 28, 2018
Merged

Fix slr deser #9409

merged 3 commits into from
Mar 28, 2018

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Mar 27, 2018 •
edited
Loading

Fix #9351

Yancey1989
Yancey1989 previously approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Yancey1989
Yancey1989 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again.

@typhoonzero typhoonzero merged commit eb62a77 into PaddlePaddle:develop Mar 28, 2018
@typhoonzero typhoonzero deleted the fix_slr_deser branch March 28, 2018 03:12
@Yancey1989 Yancey1989 mentioned this pull request Mar 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@typhoonzero @Yancey1989