added missing *.pb.h *.pb.cc generation to fix distribute build issue #9415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Mar 28, 2018
| @@ -597,6 +597,9 @@ function(grpc_library TARGET_NAME) | |||
| COMMAND ${PROTOBUF_PROTOC_EXECUTABLE} | |||
| ARGS --grpc_out "${CMAKE_CURRENT_BINARY_DIR}" -I "${PROTO_PATH}" | |||
| --plugin=protoc-gen-grpc="${GRPC_CPP_PLUGIN}" "${ABS_PROTO}" | |||
| COMMAND ${PROTOBUF_PROTOC_EXECUTABLE} | |||
There was a problem hiding this comment.
line 590 already calls protobuf_generate_cpp(grpc_proto_srcs grpc_proto_hdrs "${ABS_PROTO}"), curious why that doesn't work, and shoud line 590 be removed?
There was a problem hiding this comment.
hmm, i didn't notice this line, but this looks weird to me too. let me test if it's ok to remove the line 590.
also, I think it's good practice to put the generation command together, what's your idea?
There was a problem hiding this comment.
the build failed due to the missing of a dependency
FATALPlease specify source file or library in cc_library.
[18:58:57] -- Configuring done
[18:58:57] CMake Error at cmake/generic.cmake:206 (add_dependencies):
[18:58:57] The dependency target "sendrecvop_grpc_proto" of target "sendrecvop_grpc"
[18:58:57] does not exist.
[18:58:57] Call Stack (most recent call first):
[18:58:57] cmake/generic.cmake:616 (cc_library)
[18:58:57] paddle/fluid/operators/detail/CMakeLists.txt:2 (grpc_library)
looks we still need to add line 590 back for now
There was a problem hiding this comment.
If this just works, plz add a note here and merge this, we really need this unittest.
… fix-sendrec-ci
… fix-sendrec-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #9309
looks grpc's cpp generation is missing the *.pb.h and *.pb.cc part. adding this back in this pr
related build error msg:
https://paddleci.ngrok.io/viewLog.html?buildId=31241&tab=buildLog&buildTypeId=Paddle_DistributedUnitTestNightly&logTab=tree&filter=all&_focus=7594