Fix the order of reads and write from buffered channel #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiFeng
reviewed
Mar 28, 2018
| TEST(Channel, RecevingOrderEqualToSendingOrderWithBufferedChannel) { | ||
| TEST(Channel, RecevingOrderEqualToSendingOrderWithBufferedChannel3) { | ||
| // Test that Receive Order is same as Send Order when number of items | ||
| // sent is equal to size of buffer |
chengduoZH
reviewed
Mar 28, 2018
| std::deque<std::shared_ptr<QueueMessage>> &queue, ChannelAction action) { | ||
| while (!queue.empty()) { | ||
| // Check whether this message was added by Select | ||
| // If this was added by Select then execte the callback |
cs2be
approved these changes
Mar 28, 2018
| lock.unlock(); | ||
| send_return(); | ||
| return; | ||
| } else { | ||
| lock.unlock(); |
There was a problem hiding this comment.
I think a comment might be good here, since its not obvious why we are doing a recursive call
mikeseven
added a commit
to mikeseven/Paddle
that referenced
this pull request
Mar 30, 2018
* commit '33b8b3d22034423455a493712955e419aac7b19b': (251 commits) Remove redundant commands in build.sh and build_doc.sh Add dependencies Move v2/api/fluid to fluid/api and Adjust doc build commands Plain LRN op throws an exception when is_test is set in backward pass fix compiler error of profiler_test in ONLY_CPU mode fix server shutdown Translation for Model Configuration (PaddlePaddle#9513) Fix data transform when inplace (PaddlePaddle#9450) refine parallel add FAQ (PaddlePaddle#9494) Fix dist error with lr decay layer (PaddlePaddle#9489) add prefetch_op (PaddlePaddle#9495) Fix some errors (PaddlePaddle#9403) hookup WITH_FLUID_ONLY in TeamCity build.sh (PaddlePaddle#9509) Fix the order of reads and write from buffered channel (PaddlePaddle#9423) change WITH_FLUID to WITH_FLUID_ONLY (PaddlePaddle#9427) fix block num Revert "make append activation in place by default (PaddlePaddle#9417)" Speed/sequence op1 (PaddlePaddle#9217) fix a compile error ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9388