Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cos and sin #9449

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Add cos and sin #9449

merged 2 commits into from
Mar 29, 2018

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Mar 28, 2018 •
edited
Loading

fix #9446

@chengduoZH chengduoZH force-pushed the feature/add_cos branch 3 times, most recently from 017a5bb to a16b150 Compare March 28, 2018 12:51
@chengduoZH chengduoZH force-pushed the feature/add_cos branch 2 times, most recently from bc0bf20 to da73594 Compare March 28, 2018 15:17
@chengduoZH chengduoZH changed the title [WIP] Add cos Add cos and sin Mar 29, 2018
qingqing01
qingqing01 approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chengduoZH chengduoZH merged commit 24100e1 into PaddlePaddle:develop Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Cosine operator
2 participants
@chengduoZH @qingqing01