Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis for check broken links #946

Merged
merged 6 commits into from
Dec 21, 2016
Merged

travis for check broken links #946

merged 6 commits into from
Dec 21, 2016

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Dec 19, 2016

在travis中增加失效链接的检查,等#945 merge后能过travis ci。

@luotao1 luotao1 requested a review from reyoung December 19, 2016 08:23
exit 1
fi
done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -7,6 +7,16 @@ source ./common.sh
cmake .. -DCMAKE_BUILD_TYPE=Debug -DWITH_GPU=OFF -DWITH_DOC=ON
make paddle_docs paddle_docs_cn

# check websites for broken links
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把下面的代码,改成

linkchecker doc/cn/html/index.html
linkchecker doc/en/html/index.html

本来如果开启set -e就是在对返回值做判断,不需要在if判断一下了。

同时,就两个目录,写个循环的行数都大于直接写两个的行数了。没啥必要写循环。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented Dec 21, 2016

赞!

除了Travis,我们在本地运行 pre-commit run -a 的时候,会检查死链么?

@reyoung
Copy link
Collaborator

reyoung commented Dec 21, 2016

是不是这个PR merge之后,我们在本地运行 pre-commit run -a 的时候,也就会检查死链了

不会,只会在Travis-CI的持续集成服务器上检查。这个检查也够了,因为相当于每次合入的版本都是正确的就行了。

@luotao1 luotao1 merged commit 446e3c2 into PaddlePaddle:develop Dec 21, 2016
@luotao1 luotao1 deleted the checker branch December 21, 2016 03:55
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
* test=develop, update install doc

* add setuptools dependency

* Update compile_Ubuntu.md

update cudnn version

* Update install_Ubuntu.md

update cudnn version

* Update install_CentOS.md

update cudnn version

* test=develop, refine ubuntu cuda support

* test=develop, refine ubuntu cuda support

* test=develop, refine python support on python3.5

* fix python2 in ubuntu16.04 need gcc 5.4

* add nccl related doc

* refine doc

* add gpu fast install doc

* refine command of pip

* add avx off for mac complie

* refine code

* refine doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants