Fix cpplint errors operators detail #9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Mar 30, 2018
| @@ -2,7 +2,7 @@ if(WITH_DISTRIBUTE) | |||
| grpc_library(sendrecvop_grpc SRCS bytebuffer_stream.cc sendrecvop_utils.cc grpc_client.cc | |||
| grpc_server.cc variable_response.cc PROTO send_recv.proto DEPS lod_tensor selected_rows) | |||
| set(DISTRIBUTE_COMPILE_FLAGS "-Wno-non-virtual-dtor -Wno-error=non-virtual-dtor -Wno-error=delete-non-virtual-dtor") | |||
| set_source_files_properties(test_serde.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS}) | |||
| cc_test(serde_test SRCS test_serde.cc variable_response.cc DEPS grpc++_unsecure grpc_unsecure gpr | |||
| set_source_files_properties(serde_test.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS}) | |||
There was a problem hiding this comment.
Seems this change is mixed with #9504 ?
There was a problem hiding this comment.
Yes. It is. I am using the cpplint-fixing of dropout_op_test.cc as a "unit test" of adding the cpplint pre-commit hook.
…fix_cpplint_errors_operators_detail
…fix_cpplint_errors_operators_detail
jacquesqiao
previously approved these changes
Apr 3, 2018
… fix_cpplint_errors_operators_detail
abhinavarora
approved these changes
Apr 4, 2018
luotao1
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9505 #9506