Build: generate all the build related files into build directory not into source repo. #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wanglei828
force-pushed
the
fixmake
branch
2 times, most recently
from
85e2d7c
to
f3af0b8
Compare
luotao1
reviewed
Apr 4, 2018
| @@ -27,7 +27,7 @@ sphinx_add_target(paddle_fluid_docs | |||
| ${CMAKE_CURRENT_SOURCE_DIR} | |||
| ${SPHINX_HTML_DIR_EN}) | |||
|
|
|||
| add_dependencies(paddle_fluid_docs gen_proto_py) | |||
| add_dependencies(paddle_fluid_docs gen_proto_py paddle_python) | |||
There was a problem hiding this comment.
Why paddle_fluid_docs depends on paddle_python now?
There was a problem hiding this comment.
build_docs will scan the python import statement. If it cannot find the package, it errors
wanglei828
force-pushed
the
fixmake
branch
4 times, most recently
from
d69aea7
to
d963d3a
Compare
wanglei828
changed the title
|
@wanglei828 could you file an issue describing the problem this PR solves? |
|
@tonyyang-svail Done. |
wangkuiyi
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9671