Fix sendrecv port bind #9595
Merged
Fix sendrecv port bind #9595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
reviewed
Apr 3, 2018
| @@ -242,6 +244,9 @@ void AsyncGRPCServer::TryToRegisterNewSendOne() { | |||
| VLOG(3) << "shutdown, do not TryToRegisterNewSendOne"; | |||
| return; | |||
| } | |||
| while (scope_ == nullptr) { | |||
There was a problem hiding this comment.
These should be deleted.
|
|
||
| framework::Executor executor(dev_place); | ||
|
|
||
| // FIXME(Yancey1989): initialize rpc server with lazy mode. |
There was a problem hiding this comment.
This line is not useful.
|
|
||
| void RunServer(std::shared_ptr<detail::AsyncGRPCServer> service); | ||
|
|
||
| static void CreateTensorFromMessageType(framework::Variable *var, |
There was a problem hiding this comment.
Should we put functions' definition in header files?
typhoonzero
force-pushed
the
fix_test_sendrecv_portbind
branch
from
cd09715
to
00f8e63
Compare
… fix_test_sendrecv_portbind
wangkuiyi
previously requested changes
Apr 3, 2018
| @@ -193,6 +193,7 @@ if(WITH_DISTRIBUTE) | |||
| set_source_files_properties(send_vars_op.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS}) | |||
| op_library(send_barrier_op DEPS ${DISTRIBUTE_DEPS}) | |||
| set_source_files_properties(send_barrier_op.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS}) | |||
| set_source_files_properties(send_recv_op_test.cc PROPERTIES COMPILE_FLAGS ${DISTRIBUTE_COMPILE_FLAGS}) | |||
There was a problem hiding this comment.
Please remove the use of set_source_files_properties as discussed in #9612
There was a problem hiding this comment.
Because of grpc implementation, we have to use this when linking with grpc, and this can not be present at generic.cmake.
typhoonzero
dismissed
wangkuiyi’s stale review
Need to merge this fix first, will discuss in the issue
typhoonzero
force-pushed
the
fix_test_sendrecv_portbind
branch
from
6cd9f1e
to
a9cc9ed
Compare
… fix_test_sendrecv_portbind
typhoonzero
force-pushed
the
fix_test_sendrecv_portbind
branch
from
a9cc9ed
to
b03fa88
Compare
Yancey1989
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unit test
send_recv_op_test.ccerror binding used port.Fix grpc_server use an uninitialized scope.