Fix CPPlint errors in channel.h, channel_impl.h and channel_test.cc #9628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidgoyal78
requested changes
Apr 4, 2018
There was a problem hiding this comment.
The CI doesn't pass, i think there is some mix up with reference and pointer types. (please see CI log: https://paddleci.ngrok.io/viewLog.html?buildId=32423&buildTypeId=Paddle_PrCi&tab=buildLog&_focus=3785)
| @@ -88,15 +88,15 @@ class ChannelImpl : public paddle::framework::Channel<T> { | |||
| } | |||
|
|
|||
| std::shared_ptr<QueueMessage> get_first_message( | |||
| std::deque<std::shared_ptr<QueueMessage>> &queue, ChannelAction action) { | |||
| std::deque<std::shared_ptr<QueueMessage>> *queue, ChannelAction action) { | |||
| while (!queue.empty()) { | |||
There was a problem hiding this comment.
I think this is incorrect, since queue is a pointer, so maybe we need something like queue->empty()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.