Expose CUDAPinnedPlace to Python #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
feature/expose_CUDAPinnedPlace_to_python
branch
6 times, most recently
from
a90b1af
to
52439db
Compare
chengduoZH
force-pushed
the
feature/expose_CUDAPinnedPlace_to_python
branch
from
52439db
to
8e4e155
Compare
chengduoZH
changed the title
chengduoZH
requested review from
dzhwinter,
qingqing01,
JiayiFeng and
typhoonzero
… feature/expose_CUDAPinnedPlace_to_python
wangkuiyi
reviewed
Apr 5, 2018
paddle/fluid/framework/tensor_impl.h
Outdated
| #ifndef PADDLE_WITH_CUDA | ||
| PADDLE_THROW("'CUDAPlace' is not supported in CPU only device."); | ||
| PADDLE_THROW( | ||
| "'CUDAPlace' or 'CUDAPinnedPlace' is not supported in CPU only " |
There was a problem hiding this comment.
"CUDAPlace or CUDAPinnedPlace is not supported in CPU-only mode"| std::memcpy(dst, array.data(), sizeof(T) * array.size()); | ||
| } | ||
|
|
||
| template <> |
There was a problem hiding this comment.
I think we need a comment explaining the reason that we need this specialization:
// This following specialization maps uint16_t in the parameter type to platform::float16.
chengduoZH
force-pushed
the
feature/expose_CUDAPinnedPlace_to_python
branch
from
c15f793
to
4ff237f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9658