Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove net op and cond_op #9663

Merged
merged 14 commits into from
Apr 11, 2018

Conversation

tonyyang-svail
Copy link

@tonyyang-svail tonyyang-svail commented Apr 4, 2018

fix #9662 and #9692

Remove:

  1. NetOp
  2. CondOp: the alternative implementation of the conditional block is at conditional_block_op.cc.
  3. backward.cc and backward_test.cc: the dependency on NetOp.

Refactor:

  1. test_batch_norm.py and test_layer_norm.py: the dependency on backward.cc.

@wangkuiyi
Copy link
Collaborator

I love this PR! Thanks to @tonyyang-svail !

@chengduoZH chengduoZH self-requested a review April 11, 2018 01:32
@@ -112,119 +111,93 @@ def __set_tensor__(name, data=None):
__set_tensor__(output, data)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 72~111 can be removed.

Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonyyang-svail tonyyang-svail merged commit b26f505 into PaddlePaddle:develop Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove NetOp
4 participants