Remove not used params in GradientMachine::start #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
赞！ @reyoung |
jacquesqiao
reviewed
Dec 21, 2016
| @@ -212,11 +212,7 @@ class GradientMachine { | |||
| * @note This function will only been implemented and used in a | |||
| * multithreaded environment. | |||
| */ | |||
| virtual void start(const TrainerConfig& config, | |||
There was a problem hiding this comment.
这两个参数之前有用过。在最开始Paddle支持很多GradientMachine，有一部分GradientMachine不会关注forward的时候的数据，而会在start的时候，直接获得DataProvider，进而获得数据。
目前大部分GradientMachine都已经统一成一个MultiGradientMachine了，并且数据的输入和输出也全在forward/backward进行了，这个start的参数就用不上了。
jacquesqiao
reviewed
Dec 21, 2016
| @@ -212,11 +212,7 @@ class GradientMachine { | |||
| * @note This function will only been implemented and used in a | |||
There was a problem hiding this comment.
start之后，GradientMachine才可以做forward和backward。
对于某些GradientMachine来说，start过程会启动线程，而finish的时候会退出线程
hedaoyuan
approved these changes
Dec 21, 2016
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
* asymmetric_kernel * asymmetric_kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all unused parameters in
GradientMachine::start. Make this method easily exposed in SWIG.