Avoid init_p2p all the times #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Apr 7, 2018
| @@ -64,7 +64,7 @@ void InitP2P(int count) { | |||
| #endif | |||
| } | |||
|
|
|||
| void InitDevices() { | |||
| void InitDevices(bool init_p2p) { | |||
There was a problem hiding this comment.
It seems that InitDevice is always called with init_p2p=true. Do we plan to change some of these invocations to be with false?
There was a problem hiding this comment.
see __init__.py, For all tests, it should be false
There was a problem hiding this comment.
wangkuiyi
approved these changes
Apr 8, 2018
|
Can we set the default value of |
|
@Xreki if there are more than a handful of users, we can set the default. Otherwise, we can just ask them to change their codes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9665