Add some comments for distribute_transpiler #9735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
reviewed
Apr 8, 2018
| @@ -192,22 +194,24 @@ def transpile(self, | |||
| self.trainer_id = trainer_id | |||
| pserver_endpoints = pservers.split(",") | |||
|
|
|||
| # step1 | |||
| # step1: For large parameters and gradients, split them into smaller | |||
There was a problem hiding this comment.
Line 154 has comments already.
There was a problem hiding this comment.
I think the L154 is a good place for high level descriptions. inlining detail comments within the codes is better for readers. They can co-exists.
typhoonzero
reviewed
Apr 9, 2018
| @@ -812,6 +824,9 @@ def _get_lr_ops(self): | |||
| find_ops.append(op) | |||
| # make a union find struct by the ops in default_main_program | |||
| ufind = UnionFind(block.ops) | |||
|
|
|||
| # TODO(panyx0718): If lr_ops connects with other training | |||
There was a problem hiding this comment.
We'll use SSA to replace the current ufind structure. For current deeplearning programs, it works fine.
There was a problem hiding this comment.
Removed this comment
typhoonzero
reviewed
Apr 9, 2018
| @@ -278,6 +283,8 @@ def get_pserver_program(self, endpoint): | |||
| orig_var_name = v.name[:suff_idx] | |||
| else: | |||
| orig_var_name = v.name | |||
| #TODO(panyx0718): Should this be put in the else block below? It's | |||
There was a problem hiding this comment.
Can put directly under else
typhoonzero
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.