Modify readers to fit the parallel executor #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removes MultipleReader's multi-thread support, for we have got ThreadedReader. 2. Rename MultipleReader to MultiFileReader
… modify_readers_to_fit_parallel_executor
1. Combine 'open_files', 'multi_pass_reader' and 'threaded_reader' together to make the new 'open_files' interface. 2. Add some docstring. 3. Simplify interface names of 'create_XXX_reader', e.g, rename 'create_double_buffer_reader' to 'double_buffer'.
… modify_readers_to_fit_parallel_executor
JiayiFeng
changed the title
JiayiFeng
changed the title
reyoung
reviewed
Apr 11, 2018
| @@ -171,16 +168,26 @@ void DoubleBufferReader::ReInit() { | |||
| StartPrefetcher(); | |||
| } | |||
|
|
|||
| bool DoubleBufferReader::HasNext() const { | |||
| while (!channel_->IsClosed() && !channel_->CanReceive()) { | |||
There was a problem hiding this comment.
...We should use a conditional variable to wait here.
There was a problem hiding this comment.
I will fix it in further PRs.
reyoung
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadedReader).open_files()interface.HasNext(), for it is unsafe in multi-thread environment.