add rnn en doc #9809
Merged
add rnn en doc #9809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanyi15
reviewed
Apr 16, 2018
| The existing RNN implementations of the PaddlePaddle is `RecurrentLayerGroup`, | ||
| which supports the variable length sequences without padding. | ||
| This doc will design fluid's RNN based on this idea. | ||
|
|
There was a problem hiding this comment.
Background没有翻译，请问这部分内容是否不需要了呢？
There was a problem hiding this comment.
可以不要了，设计的时候背景变化了很多
| This doc will design fluid's RNN based on this idea. | ||
|
|
||
| ## Multi-layer sequence data format `LODTensor` | ||
| At present, Paddle will store data in one mini-batch in one-dimensional array. |
There was a problem hiding this comment.
at present和will在时间方面矛盾，可以用Paddle stores data.....
|
|
||
| `Argument.sequenceStartPositions` is used to store information for each sentence. | ||
|
|
||
| In Paddle, `Argument.subSequenceStartPositions` is used to store 2 levels of sequence information, while higher dimensional sequences can not be supported. |
There was a problem hiding this comment.
看到中文是“两层”，这里翻译为2 levels不确定是否准确（或2 layers?）
| ``` | ||
| Each `level_t` here stores a level of offset information consistent with paddle's current practice. | ||
|
|
||
| In order to transmit sequence information more transparently, we have introduced a new tensor called `LODTensor`[4]. |
There was a problem hiding this comment.
因为background里还有参考文献[1][2][3]，若不翻会导致[4]突然出现。
| }; | ||
| ``` | ||
| Among them, `lod_start_pos_` uses `shared_ptr` to reduce the cost of storage and replication. | ||
| Think of `LODTensor` as an extension of `Tensor`, which is almost completely compatible with the original `Tensor`. |
There was a problem hiding this comment.
LODTensor can be thought as an extension of Tensor
|
|
||
| ## How to support the framework | ||
| ### Replace `Tensor` with `LoDTensor` | ||
| To implement the passing of `LODTensor`, many `Tensor` in the framework need to be `LODTensor`. |
There was a problem hiding this comment.
上文中传递翻译为“transmit”,可以统一一下，在这里将passing也改为transmit
|
|
||
| ## How to support the framework | ||
| ### Replace `Tensor` with `LoDTensor` | ||
| To implement the passing of `LODTensor`, many `Tensor` in the framework need to be `LODTensor`. |
| ## How to support the framework | ||
| ### Replace `Tensor` with `LoDTensor` | ||
| To implement the passing of `LODTensor`, many `Tensor` in the framework need to be `LODTensor`. | ||
| Simple implementation, directly ** replace all previous `Tensor` with `LODTensor`, where you can directly modify the `Tensor` interface created in `pybind.cc`. |
There was a problem hiding this comment.
这里可能是想加粗，但少打了两个**,预览看没显示对
|
|
||
| In addition, the user may need to perceive the existence of a sequence (such as the sequence of the visualization needs to parse the output sequence in the model), so some of the serial operation APIs also need to be exposed to the python layer. | ||
|
|
||
| ### Pass `lod_start_pos` along with the Op call chain |
There was a problem hiding this comment.
pass----transmit可以统一一下说法
| The framework needs to support the following features to implement the passing of `lod_start_pos`: | ||
|
|
||
| 1. Implement the transfer as `shared_ptr` | ||
| - Do not modify the contents of `lod_start_pos` as a consumer |
|
这个design相当一部分内容没有实现出来，但没时间大改，所以删掉一些不一样的地方。 @shanyi15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9574