Auto-grown sparse table #9897
Merged
Auto-grown sparse table #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Apr 17, 2018
| @@ -69,5 +116,66 @@ void DeserializeFromStream(std::istream& is, SelectedRows* selected_rows, | |||
| TensorFromStream(is, selected_rows->mutable_value(), dev_ctx); | |||
| } | |||
|
|
|||
| bool SelectedRows::HasKey(int64_t key) const { | |||
There was a problem hiding this comment.
Maybe add some comments here to explain why we need these APIs for SelectedRows data structure.
typhoonzero
reviewed
Apr 17, 2018
| } | ||
|
|
||
| bool SelectedRows::Get(int64_t key, framework::Tensor* value, | ||
| int64_t row) const { |
There was a problem hiding this comment.
row is the same as key?
There was a problem hiding this comment.
No, it's the offset of the given value pointer, maybe I can rename it to offset...
typhoonzero
reviewed
Apr 18, 2018
| const T* old_ptr = | ||
| tensor_->memory_size() == 0 ? nullptr : tensor_->data<T>(); | ||
| if (old_ptr != nullptr) { | ||
| std::copy(old_ptr, old_ptr + tensor_->numel(), ptr); |
There was a problem hiding this comment.
better to use memory::copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #9841
Taks: #9211