Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpplint issues with beam_search_op and beam_search_decode_op #9962

Merged
merged 5 commits into from
Apr 17, 2018
Merged

Fix cpplint issues with beam_search_op and beam_search_decode_op #9962

merged 5 commits into from
Apr 17, 2018

Conversation

abhinavarora
Copy link
Contributor

No description provided.

@abhinavarora abhinavarora self-assigned this Apr 16, 2018
@abhinavarora abhinavarora mentioned this pull request Apr 16, 2018
Closed
sidgoyal78
sidgoyal78 previously requested changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the build fails: https://paddleci.ngrok.io/viewLog.html?buildId=33560&buildTypeId=Paddle_PrCi&tab=buildLog&_focus=7851

@abhinavarora abhinavarora dismissed sidgoyal78’s stale review April 17, 2018 19:10

Fixed the errors. Thank you for pointing that.

@abhinavarora
Copy link
Contributor Author

@sidgoyal78, Could you please review again?

sidgoyal78
sidgoyal78 approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@sidgoyal78 sidgoyal78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinavarora abhinavarora merged commit 6f83142 into PaddlePaddle:develop Apr 17, 2018
@abhinavarora abhinavarora deleted the cpplint_ops_b branch April 17, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidgoyal78 sidgoyal78 sidgoyal78 approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@cs2be cs2be Awaiting requested review from cs2be

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

Assignees

@abhinavarora abhinavarora

Labels
Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhinavarora @sidgoyal78