Prettify output #200
Merged
Prettify output #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
reviewed
Jul 4, 2017
| elif [ $ret -eq 1 ] ; then | ||
| echo "General Error" > /dev/termination-log | ||
| elif [ $ret -eq 134 ] ; then | ||
| echo "Program Abort" > /dev/termination-log |
There was a problem hiding this comment.
Deal with an unknown return code?
There was a problem hiding this comment.
unknown就不现实message了，ret code还是可以看到的
go/paddlecloud/get.go
Outdated
| w := tabwriter.NewWriter(os.Stdout, 0, 0, 3, ' ', 0) | ||
| if len(items) >= 0 { | ||
| fmt.Fprintf(w, "NUM\tNAME\tSUCC\tFAIL\tSTART\tCOMP\tACTIVE\t\n") | ||
| fmt.Fprintf(w, "NAME\tACTIVE\tSUCC\tFAIL\tSTART\tCOMP\tPS_NAME\tPS_READY\tPS_TOTAL\t\n") |
There was a problem hiding this comment.
What's the PS_NAME used for? Maybe only print the stats of PServer?
There was a problem hiding this comment.
replicaset的name不过对于用户来说没什么用了倒是。可以去掉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #195
Note here's still a problem when train exited with error, submit with:
will not show message when
paddlecloud get workers [jobname]