Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #225

Merged
merged 3 commits into from
Jul 18, 2017
Merged

Fix bugs #225

merged 3 commits into from
Jul 18, 2017

Conversation

gongweibao
Copy link
Collaborator

No description provided.

@@ -79,5 +79,7 @@ spec:
env:
- name: MYSQL_ROOT_PASSWORD
value: root
- name: MYSQL_DATABASE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the environment key MYSQL_DATASE used for?

Copy link
Collaborator Author

@gongweibao gongweibao Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有数据库就会建一个数据库。:)
https://hub.docker.com/_/mysql/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, got it.

Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -79,5 +79,7 @@ spec:
env:
- name: MYSQL_ROOT_PASSWORD
value: root
- name: MYSQL_DATABASE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, got it.

@gongweibao gongweibao merged commit 5e70a76 into PaddlePaddle:develop Jul 18, 2017
@gongweibao gongweibao deleted the review branch August 21, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants