Skip to content

Commit

Permalink
fix distdataloader, fix eval with dp group (#8420)
Browse files Browse the repository at this point in the history
  • Loading branch information
DesmonDay committed May 13, 2024
1 parent f27fdb4 commit 6bd2b0d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions paddlenlp/data/dist_dataloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ def _broadcast_data(self, data):
src=self._pp_group.ranks[0],
group=self._pp_group,
)
else:
fake_data = [None]

fake_data = fake_data[0]
if fake_data is None:
Expand Down
4 changes: 2 additions & 2 deletions paddlenlp/trainer/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1450,15 +1450,15 @@ def get_eval_dataloader(self, eval_dataset: Optional[Dataset] = None) -> DataLoa
eval_dataset,
batch_size=self.args.per_device_eval_batch_size,
collate_fn=self.data_collator,
num_workers=self.args.dataloader_num_workers,
num_workers=0,
eval=True,
)
else:
return DataLoader(
eval_dataset,
batch_size=self.args.per_device_eval_batch_size,
collate_fn=self.data_collator,
num_workers=self.args.dataloader_num_workers,
num_workers=0,
)

eval_sampler = self._get_eval_sampler(eval_dataset)
Expand Down

0 comments on commit 6bd2b0d

Please sign in to comment.