Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add End-to-End Memory Network example #1046

Merged
merged 14 commits into from
Nov 29, 2021
Merged

Add End-to-End Memory Network example #1046

merged 14 commits into from
Nov 29, 2021

Conversation

yulangz
Copy link
Contributor

@yulangz yulangz commented Sep 17, 2021

PR types

复现赛模型提交

PR changes

完成End to End Memory Networks的复现

Description

使用Paddle复现End to End Memory Networks

@yingyibiao yingyibiao self-assigned this Sep 17, 2021
@yingyibiao yingyibiao changed the title Dev Add End-to-End Memory Network example Sep 17, 2021
ZeyuChen
ZeyuChen reviewed Oct 30, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yingyibiao 是否可以作为语言模型的一个示例？

@yingyibiao
Copy link
Contributor

@yingyibiao 是否可以作为语言模型的一个示例？

@yingyibiao 是否可以作为语言模型的一个示例？

是可以的

@wawltor wawltor requested a review from ZHUI November 2, 2021 02:09
@yingyibiao yingyibiao assigned ZHUI and unassigned yingyibiao Nov 2, 2021
ZHUI
ZHUI reviewed Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体看，代码风格有一些问题。

另外，这里使用了pre-commit格式化代码吗？

examples/end_to_end_memory_networks/README.md Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/README.md Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/README.md Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/README.md Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/README.md Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/train.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/train_until.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/model.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/model.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/model.py Outdated Show resolved Hide resolved
ZHUI
ZHUI reviewed Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个版本修改后，代码看起来清晰很多。还有一些注释风格问题，可以继续改进一下

examples/end_to_end_memory_networks/eval.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/model.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/model.py Outdated Show resolved Hide resolved
examples/end_to_end_memory_networks/train.py Outdated Show resolved Hide resolved
@ZHUI ZHUI requested a review from yingyibiao November 20, 2021 04:11
@yingyibiao
Copy link
Contributor

建议该模型放在examples/language_model目录下

yingyibiao
yingyibiao approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingyibiao yingyibiao merged commit 462f080 into PaddlePaddle:develop Nov 29, 2021
@yulangz yulangz deleted the dev branch November 29, 2021 12:19
@yulangz yulangz restored the dev branch November 29, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen left review comments

@ZHUI ZHUI ZHUI left review comments

@yingyibiao yingyibiao yingyibiao approved these changes

Assignees

@ZHUI ZHUI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yulangz @yingyibiao @ZeyuChen @ZHUI @chenxiaozeng