Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaddlePaddle Hackathon 54 提交 #1086

Merged
merged 21 commits into from
Oct 25, 2021
Merged

PaddlePaddle Hackathon 54 提交 #1086

merged 21 commits into from
Oct 25, 2021

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Sep 24, 2021

Task: #1076

  • 权重文件等百度云上传,链接:https://pan.baidu.com/s/1sonj-M_qVTkvRzYdM781Kg 提取码:79s9。
  • huggingface的ElectraGeneratorPredictions中nn.LayerNorm没有设置eps=1e-12,paddlenlp中设置了1e-12。
  • hfl-chinese-legal-electra-small-generator权重官方的config配置存在错误,他错误的使用了discriminator的配置,因此我人工修正了一下。
  • 添加compare.py比较转换后的模型预测结果。(该文件所处位置等审核通过后再修改)。
  • 添加convert.py转换脚本。(该文件所处位置等审核通过后再修改)。
  • 添加ElectraForMaskedLM, ElectraForQuestionAnswering和ElectraForMultipleChoice这三个类。
  • 支持2d的attention mask。
  • 添加单元测试代码。TestElectraForMaskedLM,TestElectraForQuestionAnswering和TestElectraForMultipleChoice。
  • windows条件下,paddle.int可能是int32,显示转换成int64。
  • 添加好多注释,ElectraModel设置默认初始参数。

@yingyibiao
Copy link
Contributor

community/junnyu目录下面的各个文件夹里面只需要 README.mdfiles.json 这两个文件,其他在百度网盘上传即可。

Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如上

@JunnYu
Copy link
Member Author

JunnYu commented Oct 13, 2021

community/junnyu目录下面的各个文件夹里面只需要 README.mdfiles.json 这两个文件,其他在百度网盘上传即可。

修改完成,发现在我提交这个PR之后,paddle develop中竟然更新了部分electra模型的文档,然后我这边修复了当中的部分错误。

@yingyibiao
Copy link
Contributor

Task: #1076

  • 权重文件等百度云上传,链接:https://pan.baidu.com/s/1sonj-M_qVTkvRzYdM781Kg 提取码:79s9。
  • huggingface的ElectraGeneratorPredictions中nn.LayerNorm没有设置eps=1e-12,paddlenlp中设置了1e-12。
  • hfl-chinese-legal-electra-small-generator权重官方的config配置存在错误,他错误的使用了discriminator的配置,因此我人工修正了一下。
  • 添加compare.py比较转换后的模型预测结果。(该文件所处位置等审核通过后再修改)。
  • 添加convert.py转换脚本。(该文件所处位置等审核通过后再修改)。
  • 添加ElectraForMaskedLM, ElectraForQuestionAnswering和ElectraForMultipleChoice这三个类。
  • 支持2d的attention mask。
  • 添加单元测试代码。TestElectraForMaskedLM,TestElectraForQuestionAnswering和TestElectraForMultipleChoice。
  • windows条件下,paddle.int可能是int32,显示转换成int64。
  • 添加好多注释,ElectraModel设置默认初始参数。

权重相关文件已上传bos

@yingyibiao
Copy link
Contributor

参照 #1085 的review意见修改类似问题~

@yingyibiao
Copy link
Contributor

Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingyibiao yingyibiao merged commit 723becf into PaddlePaddle:develop Oct 25, 2021
@JunnYu JunnYu deleted the update_electra branch October 25, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants