Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade paddlenlp.layers.crf.ViterbiDecoder to paddle.text.ViterbiDecoder compatibly #1291

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Upgrade paddlenlp.layers.crf.ViterbiDecoder to paddle.text.ViterbiDecoder compatibly #1291

merged 5 commits into from
Nov 10, 2021

Conversation

joey12300
Copy link
Contributor

@joey12300 joey12300 commented Nov 10, 2021 •
edited
Loading

PR types

Performance optimization

PR changes

Models

Description

  1. Remove some unnecessary ViterbiDecoder imports
  2. Add compare_version tool which can be used to compare paddle version
  3. Upgrade all models related to crf from paddlenlp.layers.crf.ViterbiDecoder to paddle.text.ViterbiDecoder

Affected model

  1. BiGRUWithCRF of waybill and lac task(in both examples and taskflow)
  2. ERNIE-CTM
  3. SKEP

@joey12300 joey12300 changed the title Upgrade paddlenlp.layers.crf.ViterbiDecoder to paddle.text.ViterbiDecoder Upgrade paddlenlp.layers.crf.ViterbiDecoder to paddle.text.ViterbiDecoder compatibly Nov 10, 2021
ZeyuChen
ZeyuChen approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen added this to In progress in PaddleNLP v2.2 via automation Nov 10, 2021
@ZeyuChen ZeyuChen merged commit 80f62d3 into PaddlePaddle:develop Nov 10, 2021
PaddleNLP v2.2 automation moved this from In progress to Done Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
PaddleNLP v2.2
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joey12300 @ZeyuChen