[BUGFIX] Cnn_dailymail and xnli raise error when downloading in multi-gpus mode #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyuChen
reviewed
Jan 15, 2022
paddlenlp/datasets/xnli.py
Outdated
| .trainer_endpoints[:]) | ||
| if ParallelEnv().current_endpoint in unique_endpoints: | ||
| file_num = len(os.listdir(fullname)) | ||
| if file_num != 15: |
guoshengCS
reviewed
Jan 26, 2022
| .trainer_endpoints[:]) | ||
| if ParallelEnv().current_endpoint in unique_endpoints: | ||
| file_num = len(os.listdir(fullname)) | ||
| if file_num != len(ALL_LANGUAGES): |
There was a problem hiding this comment.
这里稍微说明下背景，相比其他数据集这里多了file_num = len(os.listdir(os.path.join(dir_path, "stories")))，这个在多进程下有些问题，当前多进程下载解压机制假定了_get_data中的文件相关操作是制定节点上的，咱们数据集依赖的 get_path_from_url 是符合这个假设的，这避免了绝大部分数据集多进程下载解压的问题，这里的file_num = len(os.listdir(os.path.join(dir_path, "stories")))不太一样，这个PR是临时修复办法，后续可以在从数据集层面解决下
There was a problem hiding this comment.
这里稍微说明下背景，相比其他数据集这里多了
file_num = len(os.listdir(os.path.join(dir_path, "stories")))，这个在多进程下有些问题，当前多进程下载解压机制假定了_get_data中的文件相关操作是制定节点上的，咱们数据集依赖的get_path_from_url是符合这个假设的，这避免了绝大部分数据集多进程下载解压的问题，这里的file_num = len(os.listdir(os.path.join(dir_path, "stories")))不太一样，这个PR是临时修复办法，后续可以在从数据集层面解决下
好的 Thx
guoshengCS
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description